Skip to content

Greenkeeper/parse server s3 adapter 1.2.0 #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

acinader
Copy link
Contributor

No description provided.

@acinader
Copy link
Contributor Author

acinader commented Aug 26, 2017

@flovilmart this what you have in mind? see #4016 for context....

CHANGELOG.md Outdated
@@ -1,5 +1,11 @@
## Parse Server Changelog

### 2.5.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use master as untagged for now

CHANGELOG.md Outdated
### 2.5.4
[Full Changelog](https://github.com/ParsePlatform/parse-server/compare/2.5.4...2.5.4)

#### New DeprecationNotice:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, or mark it ‘Breaking Changes’

@flovilmart
Copy link
Contributor

Perhaps should be 2.6.0

@acinader acinader force-pushed the greenkeeper/parse-server-s3-adapter-1.2.0 branch from f470a76 to 471d3c0 Compare August 26, 2017 23:44
@acinader acinader force-pushed the greenkeeper/parse-server-s3-adapter-1.2.0 branch from 471d3c0 to c213289 Compare August 26, 2017 23:49
@acinader
Copy link
Contributor Author

I'm a little confused by your comment on master. Is this what you mean?

@codecov
Copy link

codecov bot commented Aug 27, 2017

Codecov Report

Merging #4118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4118   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files         116      116           
  Lines        7939     7939           
=======================================
  Hits         7203     7203           
  Misses        736      736
Impacted Files Coverage Δ
src/RestWrite.js 92.78% <0%> (-0.19%) ⬇️
src/Push/PushWorker.js 92.45% <0%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea67d23...8770bf8. Read the comment docs.

@flovilmart
Copy link
Contributor

@acinader that's OK, let's go with that!

@flovilmart flovilmart merged commit f840394 into parse-community:master Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants